I bet this turns into one of those 'religious' discussions......but they're always fun to a point!
Of course, like anything else, YMMV depending on the intended purpose of your fenders, your ability and willingness to store them, etc, etc....
With Misty, I don't fenders to stay off of my dock, and rarely for other docks that I visit, most of which have poles or skirting to keep the boat off. Mostly, they are used for rafting with other vessels or keeping the tender off the side.
I prefer the long, double ended fenders so they can be secured vertically, or horizontally. With lines on both ends, it's easier to keep them where you want them as well. It's a pain to run the line through the center of the hollow ones, so I tend to buy them with eyes on both ends. I also have a couple of ball fenders which are great for keeping hulls apart below the sheer line, but they're a pain to stow and don't look good sitting up on the deck.
For color, black seems to be "in" in my area, but I tend to buy white. A couple of years back, I had fender covers with line pockets made out of sunbrella to match the canvas on the boat. Love them. I tried the WM "socks", which wear and fray quickly.
For brand, it's hard to beat Taylor's warranty. I've brought some back with the center tube ripped out to receive new replacements from WM, but I'm told that level of responsiveness varies from store to store. As long as they are not cut, Taylor will replace them.
If I were doing the "loop" and locking a lot, I would probably have more, and bigger, ball fenders on deck.